Apply pointing correction to SAT sim#1675
Conversation
ykyohei
requested review from
adrien-laposta,
chervias,
kwolz and
yoshinori-0778
| logger.info("Reading in simulated map") | ||
| demod_mm.from_map(aman, sim_map, wrap=True, modulated=True, interpol=interpol) | ||
| demod_mm.from_map(aman, sim_map, wrap=True, modulated=True, | ||
| interpol=interpol, sight=sight) |
There was a problem hiding this comment.
Just for curiosity, does this also need to be propagated when we do the inverse operation, i.e. tod->map ? In which case we'll have to modify the small function in the filtering script
There was a problem hiding this comment.
Exactly! Inverse tod->map operation is PRed here simonsobs/bb-awg-scripts#21
There was a problem hiding this comment.
Looks great, thanks for making this!
One question, which might related to Adri's question, is that is this bb-awg-scripts using map making? Wobble correction is already in here, and I though we have used this to make an atmic map.
There was a problem hiding this comment.
Yeah I was confused as well. The data pipeline which you linked had wobble option already, but the tf pipeline is different and it is in awg repo and it didn't have wobble correction option, so I made a PR.
There was a problem hiding this comment.
I see, bb-pwg-scripts is used for TF. That makes sense. Thank you!
There was a problem hiding this comment.
We might want to merge the two if possible (in the future) so that we don't duplicate code and use a single mapmaking function.
There was a problem hiding this comment.
The reason I didn't directly integrate wobble to mapmaking function is because it only works when all the dets belong to single wafer band.
Also I think it might be cleaner to integraye wobble to pointing model, not pointing matrix.
3 participants
Apply both boreight pointing model and pointing wobble to SAT simulation. wobble is optional.
Another PR of bb-awg-scripts: simonsobs/bb-awg-scripts#21
Tested this using boresight pointing of obs_1731438172_satp3_1111111, ws1, f090
The middle one is difference of no wobble and wobble input only. We see residual in small scale as expected.
The bottom one is difference of no wobble and wobble correction both input and output (mapmaking). SInce these two scans slgihtly different region of sky, we see residual at the edge of map, as expected.