Complete level 2 cleanup reorganization#1669
Merged
Merged
Conversation
…3thk loop (#1671) * Only log in the cases of unexpected exceptions (not TypeErrors) for g3thk loop * Include error in log message
* expand update_g3tsmurf_db to accept minimum and maximum ctimes * print time differences * change variable names and expose delay warning and error to argparse * comment formatting * Update sotodlib/io/imprinter.py Co-authored-by: Josh Borrow <josh@joshborrow.com> * Update sotodlib/io/imprinter.py Co-authored-by: Josh Borrow <josh@joshborrow.com> * Apply suggestions from code review Co-authored-by: Josh Borrow <josh@joshborrow.com> * remove int casting and set defaults through the system * add option to automatically register books as bad when removing a level 2 obs. closes #1438 * fix counter logic. closes #1666 * prevent missing files from throwing deletion errors * add additional counter checks * improve handling for BadTimeSamples since I've realized missing files is a bigger issue * close the bookbinder log * add timing counter errors to autofixing * remove log statement * other binders need a close * only close bookbinder if it exists --------- Co-authored-by: Josh Borrow <josh@joshborrow.com>
Member
Author
|
I've now tested and run this over everything. Ready to deploy. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm going to admit to having used Claude to help reorganize this. It's going to substantially reduce the number of times we run through the file system and databases as we are cleaning things up. (I don't think this will be enough to shorten LATs runtime but it's a start).
This changes how the cleanup loops work:
Before:
After
Other changes