Stimulator analysis pipeline#1659
Merged
Merged
Conversation
ykyohei
reviewed
Jun 11, 2026
ykyohei
left a comment
ykyohei
left a comment
Contributor
There was a problem hiding this comment.
It's great to see the simulator pipeline in sotodlib!
Preliminary review comments. sotodlib follows PEP8, but whitespace is missing after commas in many places. I suggest running a linter and correcting them.
ykyohei
reviewed
Jun 17, 2026
ykyohei
left a comment
ykyohei
left a comment
Contributor
There was a problem hiding this comment.
Thanks! it's getting much better!
I guess I found few bugs, please check.
ykyohei
reviewed
Jun 24, 2026
ykyohei
reviewed
Jun 24, 2026
ykyohei
left a comment
ykyohei
left a comment
Contributor
There was a problem hiding this comment.
Thanks for all the changes, almost there!
overwrite=True is used in many places. I think these were convenient when developping pipeline but these are not really necessary. I'll let you decide but and it might be safer to remove.
Contributor
|
Looks good, thank you! |
ykyohei
approved these changes
Jun 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I wrote stimulator analysis code. Main functions are
calc_gain()andcalc_timeconstant().calc_gain()calculates stimulator's signal amplitude.calc_timeconstant()calculates optical time constant and readout delay.