Skip to content

test(zoo): characterise IKEA ALPSTUGA display-OnOff phantom relay (#64) #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
simons-plugins merged 1 commit into from
Jun 13, 2026
Merged

test(zoo): characterise IKEA ALPSTUGA display-OnOff phantom relay (#64) #65

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion indigo-matter.indigoPlugin/Contents/Info.plist
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
<key>IwsApiVersion</key>
<string>1.0.0</string>
<key>PluginVersion</key>
<string>2026.2.24</string>
<string>2026.2.25</string>

@coderabbitai coderabbitai Bot Jun 13, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major | ⚡ Quick win

Use a new, unused plugin version for this release.

Line 23 sets PluginVersion to 2026.2.25, but the version-check job already reports tag v2026.2.25 exists, so this change cannot pass CI/release gates.

Suggested fix 
-	<string>2026.2.25</string>
+	<string>2026.2.26</string>
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
<string>2026.2.25</string>
<string>2026.2.26</string>
🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@indigo-matter.indigoPlugin/Contents/Info.plist` at line 23, The PluginVersion
value in Info.plist (the <string> element currently set to 2026.2.25) must be
changed to a new, unused version string so CI/version-check passes; open
indigo-matter.indigoPlugin/Contents/Info.plist, locate the PluginVersion string
(line with <string>2026.2.25</string>), increment or otherwise change it to a
fresh version (e.g., 2026.2.26 or whatever follows your release scheme) that has
no existing git tag, commit that change, and ensure the tag/checker will
succeed.

Source: Pipeline failures

<key>ServerApiVersion</key>
<string>3.6</string>
</dict>
Expand Down
16 changes: 16 additions & 0 deletions tests/test_device_zoo.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,6 +146,22 @@ def _raw(node_id, eps):
_raw(18, {1: {"29/0": [{"0": 773}], "1027/0": 1013, "1028/0": 25}}),
{1: ["matterFlowSensor", "matterPressureSensor"]},
),
# IKEA ALPSTUGA (real Matter-over-Thread air-quality sensor): AirQuality +
# CO2 + PM2.5 + temperature + humidity, plus an OnOff cluster that toggles
# the front DISPLAY (a "dead front" control), not power. CHARACTERISES the
# issue #64 wrinkle: the display OnOff produces a generic matterRelay
# alongside the five sensors. Kept in `expected` deliberately — when #64 is
# fixed (OnOff with the DeadFront feature should not become a relay) the
# matterRelay entry is removed here in the same change. The at-most-one-
# actuator invariant still holds (one relay), so this stays a phantom-device
# note, not a duplicate-actuator failure.
"ikea_alpstuga": (
_raw(0x99, {1: {"29/0": [{"0": 44}], "91/0": 1, "1037/0": 600.0,
"1066/0": 8.0, "1026/0": 2150, "1029/0": 4800,
"6/0": False}}),
Comment on lines +159 to +161

@coderabbitai coderabbitai Bot Jun 13, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major | ⚡ Quick win

Encode the DeadFront discriminator in the raw fixture, not just OnOff state.

Lines 159-161 only model 6/0 (OnOff value). The comment says this entry characterizes the DeadFront display-control wrinkle for #64, but that discriminator isn’t present in the synthetic node payload, so the fixture can’t reliably validate a DeadFront-specific fix.

Suggested direction 
-        _raw(0x99, {1: {"29/0": [{"0": 44}], "91/0": 1, "1037/0": 600.0,
-                        "1066/0": 8.0, "1026/0": 2150, "1029/0": 4800,
-                        "6/0": False}}),
+        _raw(0x99, {1: {"29/0": [{"0": 44}], "91/0": 1, "1037/0": 600.0,
+                        "1066/0": 8.0, "1026/0": 2150, "1029/0": 4800,
+                        "6/0": False,
+                        # add the real OnOff feature discriminator(s) captured
+                        # from matter-server for ALPSTUGA display control
+                        "6/<feature_attr_id>": <captured_value>}}),
🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@tests/test_device_zoo.py` around lines 159 - 161, The test fixture _raw(0x99,
{1: {...}}) currently only includes the OnOff attribute "6/0" but omits the
DeadFront discriminator, so update that same dict passed to _raw to include the
DeadFront discriminator attribute used by the detection logic (i.e., add the
discriminator key/value alongside "6/0" in the endpoint 1 payload) so the
synthetic node payload will exercise the DeadFront-specific code path and
validate the fix.

{1: ["matterAirQualitySensor", "matterCO2Sensor", "matterHumiditySensor",
"matterPM25Sensor", "matterRelay", "matterTemperatureSensor"]},
),
# An endpoint made only of clusters we don't handle (RVC RunMode 0x0054):
# the registry yields nothing — device_sync's matterUnknown fallback takes
# over (covered in test_device_sync.py).
Expand Down
Loading