docs: remove private-ADR references from the public repo#63
Conversation
ADR-0006 lives in the private Domio repo; the public repo and the GitHub Pages site were pointing readers at a document they cannot reach. All references replaced with self-contained wording — the share model is fully explained in docs/MATTER.md / matter.html, which now stand as the public record of the decision. Also tightened the fabrics claim while in there: "typically 5+" → the spec requires every certified device to accept at least five fabrics. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
Warning Review limit reached
More reviews will be available in 54 minutes and 13 seconds. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more credits in the billing tab to continue. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThis PR consolidates Matter plugin documentation by removing internal ADR-0006 references and redirecting readers to user-facing guides, expands the Matter commissioning and firmware documentation with clarity on specifications and OTA providers, synchronizes the HTML documentation mirror, and increments the plugin version. ChangesDocumentation consolidation and enrichment
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…dor apps Apple Home auto-updates Matter accessory firmware (observed on the house Tapo plug); the vendor app just typically gets releases first. Soften the vendor-app-only framing in MATTER.md and matter.html. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…d count "Many accept more" oversold it: each fabric slot costs persistent storage, so embedded SDKs default to the minimum and most devices ship exactly five. Say "treat five as your planning number" instead. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
ADR-0006 lives in the private Domio repo, but README, CLAUDE.md, INSTALL.md, MATTER.md, the PRD, HANDOVER's section heading, and the live Pages page (matter.html) all referenced it — pointing public readers at a document they can't reach.
All references are replaced with self-contained wording;
docs/MATTER.md/matter.htmlalready explain the share model fully and now stand as the public record of the decision. No reference to the private repo's ADR (or the workspace mirror) remains — verified with a repo-wide grep.Bonus accuracy fix prompted by review: the fabrics paragraph's "typically 5+" now states the real reason — the Matter spec requires every certified device to accept at least five fabrics (the
SupportedFabricsminimum); many accept more.Docs-only; 765 tests pass. Version: 2026.2.23 → 2026.2.24 (patch, for the version-check gate). Pages updates on merge.
🤖 Generated with Claude Code
Summary by CodeRabbit
Documentation
Chores