Support paste (Command-V) on macOS#110
Merged
Merged
Conversation
Owner
|
Looks good, thanks Pete! I've no problem with AI if it's used as a targetted scalpel and not a vibe-coded bulldozer. I'm still overhauling the user-interface to remove the platform specifics, but I'm not quite decided on its final form yet. It's long overdue that macOS and Linux get the same level of support as Windows. Maintaining a single UI makes development and testing a lot easier too. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey Simon!
As you liked the last feature, here is another one. On Windows I saw you could paste from the clipboard, but not under SDL. This patch adds paste support to the SDL build, with a menu on macOS (Edit -> Paste (Cmd+V)). This mirrors the Windows menu option Tools -> Paste Clipboard. On Linux you'd still need to wire it up via the fkeys config (no menu added there). I'm happy to add a Linux UI hook in a follow-up if you like.
One incidental refactor: I moved the Action::Paste handler from Win32/UI.cpp into Base/Actions.cpp so it could be shared.
Let me know what you think! I had some help from Claude on this one, I have to level with you. Luckily though it has quite a small footprint, as I think you had done most of the hard work already!
I've tested quite a bit on macOS, and it works well for me. I'm able to paste entire SAM BASIC programs into the editor etc.
Thanks,
Pete