add per column summary statistics to the inventory resource#370
Open
lindsaywiard wants to merge 8 commits into
Open
add per column summary statistics to the inventory resource#370lindsaywiard wants to merge 8 commits into
lindsaywiard wants to merge 8 commits into
Conversation
Collaborator
Author
|
I can work on these merge conflicts tomorrow and update you when I get them figured out :) |
Collaborator
Author
|
Should be ready for review! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
summaryto eachColumn, populated at completion time.summarize.pybuilds the stats graphsave_parquet/save_parquet_replacereplaced by*_with_summaryvariants that return stats alongside the pathupdate_statusChanges
schema.py— addedContinuousColumnSummary,CategoricalColumnSummary,ColumnSummaryunion,summaryfield onColumntest_schema.py— round-trip tests for both summary discriminator variantstest_duplicate_router.py,test_modifications_router.py,test_treatments_router.py— updated columns assertions to expectsummary: Nonesummarize.py— new,_build_column_stats_graphreturns lazy dask scalars per columnstorage.py—_compute_write_and_statsfuses stats with the write; replacessave_parquet/save_parquet_replacewith*_with_summaryvariantshandlers/pim.py,handlers/chm.py,handlers/modifications.py,handlers/treatments.py— swapped call sites, returncolumnsin result dictmain.py—update_statusgains acolumnsparam, writes summaries to Firestore on completiontest_summarize.py— new, unit tests for stat correctness, null handling, and categorical unique countintegration/test_storage.py— new, single-pass regression test for both write functionshandlers/conftest.py— new, shared column constants for handler testschm_lmf.json,chm_vwf.json,pim_treemap.json— addedcolumnsfield