Skip to content

FIX re-roll editable form field names on duplicate, add parentID to name-based search - #1447

Open
andrewandante wants to merge 3 commits into
silverstripe:7from
mediasuitenz:FIX/prevent_editable_form_field_name_duplication
Open

FIX re-roll editable form field names on duplicate, add parentID to name-based search#1447
andrewandante wants to merge 3 commits into
silverstripe:7from
mediasuitenz:FIX/prevent_editable_form_field_name_duplication

Conversation

@andrewandante

@andrewandante andrewandante commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

Description

Gives duplicated fields unique Name attributes and adds additional ParentID filter to name-based lookup on validate.

Manual testing steps

Create form
Duplicate form
See that form fields, while otherwise identical, have different names

Issues

#1446

Pull request checklist

  • The target branch is correct
  • All commits are relevant to the purpose of the PR (e.g. no debug statements, unrelated refactoring, or arbitrary linting)
    • Small amounts of additional linting are usually okay, but if it makes it hard to concentrate on the relevant changes, ask for the unrelated changes to be reverted, and submitted as a separate PR.
  • The commit messages follow our commit message guidelines
  • The PR follows our contribution guidelines
  • Code changes follow our coding conventions
  • This change is covered with tests (or tests aren't necessary for this change)
  • Any relevant User Help/Developer documentation is updated; for impactful changes, information is added to the changelog for the intended release
  • CI is green

@andrewandante
andrewandante marked this pull request as ready for review August 6, 2026 04:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant