FIX Explicitly add php ppa - #175
Merged
Merged
Conversation
emteknetnz
marked this pull request as ready for review
June 23, 2026 04:11
blueo
approved these changes
Jun 23, 2026
Comment on lines
+271
to
+273
| # ppa:ondrej/apache2 is not added by default. | ||
| # ppa:ondrej/php must also be added explicitly - while shivammathur/setup-php installs the PHP CLI, | ||
| # it does not leaves the PPA registered in apt sources |
There was a problem hiding this comment.
Suggested change
| # ppa:ondrej/apache2 is not added by default. | |
| # ppa:ondrej/php must also be added explicitly - while shivammathur/setup-php installs the PHP CLI, | |
| # it does not leaves the PPA registered in apt sources | |
| # Neither ppa:ondrej/php nor ppa:ondrej/apache2 are added by default. | |
| # ppa:ondrej/php must be added explicitly - while shivammathur/setup-php installs the PHP CLI, | |
| # it does not leave the PPA registered in apt sources, which is needed for libapache2-mod-php below. |
emteknetnz
force-pushed
the
pulls/2.0/fix-ci
branch
from
June 23, 2026 22:26
fccdad8 to
4c0d7fc
Compare
michalkleiner
approved these changes
Jun 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #174
Manually tested it resolves issue on https://github.com/emteknetnz/silverstripe-campaign-admin/actions/runs/28001189905/job/82873754759