Skip to content

feature/BA-3289-rn-comments-infinite-scrolling#385

Open
davidbermudez-tsl wants to merge 2 commits into
epic/BA-2239-react-native-commentsfrom
feature/BA-3289-rn-comments-infinite-scrolling
Open

feature/BA-3289-rn-comments-infinite-scrolling#385
davidbermudez-tsl wants to merge 2 commits into
epic/BA-2239-react-native-commentsfrom
feature/BA-3289-rn-comments-infinite-scrolling

Conversation

@davidbermudez-tsl

Copy link
Copy Markdown
Collaborator

No description provided.

@changeset-bot

changeset-bot Bot commented Jun 10, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: e5ac954

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai

coderabbitai Bot commented Jun 10, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: c2c37cd2-fa8d-49bb-a75b-08e7b4214c5e

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feature/BA-3289-rn-comments-infinite-scrolling

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@davidbermudez-tsl davidbermudez-tsl requested review from lbjunq and nossila and removed request for lbjunq June 10, 2026 21:05
import { View } from '@baseapp-frontend/design-system/components/native/views'
import { useTheme } from '@baseapp-frontend/design-system/providers/native'

import { FlatList } from 'react-native'

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@davidbermudez-tsl can we use InfiniteScrollerView instead?

@nossila nossila force-pushed the feature/BA-3286-rn-delete-a-comment branch from 3abb942 to 6e78157 Compare June 18, 2026 16:53
Base automatically changed from feature/BA-3286-rn-delete-a-comment to epic/BA-2239-react-native-comments June 18, 2026 16:58
@nossila nossila force-pushed the feature/BA-3289-rn-comments-infinite-scrolling branch from fba1a2e to b19a1e1 Compare June 18, 2026 18:05
…ommentsList

Replace the raw FlatList with the design-system InfiniteScrollerView
(FlashList-based), using its built-in isLoading footer instead of a
manual ActivityIndicator, matching the NotificationsList pattern.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@sonarqubecloud

Copy link
Copy Markdown

@nossila nossila requested a review from anicioalexandre June 18, 2026 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants