fix(plan-tuner): cleanup — DRY retry, formatValue, progressionRule - #62
Merged
Conversation
…rogressionRule - Extract completeWithRetry to services/ai/retry-utils.ts (DRY refactor from report-generator.ts + tuner.ts) - Un-export mapPlanRow/mapVersionRow/mapAdjustmentRow (module-private, only used internally by query functions) - Fix AdjustmentReviewModal formatValue to handle PlanSet[] arrays directly instead of falling through to JSON.stringify - Infer progressionRule from exercise metadata SFR tier (S-tier compounds get 'linear' for 2-for-2 rule, others get 'double') Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Post-merge cleanup for Workout Plan Fine Tuner v1 (PR #60). Addresses 4 items from the retro
followUpslist.completeWithRetrytoservices/ai/retry-utils.ts— eliminates byte-for-byte duplication betweenreport-generator.tsandtuner.tsmapPlanRow/mapVersionRow/mapAdjustmentRow— module-private helpers, only used internally by query functionsAdjustmentReviewModal.formatValuedisplay bug — handlesPlanSet[]arrays directly instead of falling through toJSON.stringifyprogressionRulefrom exercise metadata SFR tier — S-tier compounds (bench/squat/deadlift/OHP) now get'linear'(2-for-2 rule), others stay'double'. Previously all parsed exercises got'double', making the 2-for-2 rule dead code for imported plans.Test plan
🤖 Generated with Claude Code