Make deploy script compatible with macOS#447
Open
r0x0r wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
Fixes dependencies/deploy.sh so CRD names are passed to the xargs-spawned bash processes as positional parameters (instead of being interpolated via xargs -I{}), aiming to avoid macOS xargs: command line cannot be assembled, too long failures during CRD establishment waits.
Changes:
- Switch CRD handling from
xargs -I{}substitution tobash -c ... _ <crd>withCRD="$1". - Add the dummy
$0argument (_) required for correct$1positioning inbash -c.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
86
to
+88
| yq -r 'select(.kind == "CustomResourceDefinition") | .metadata.name' "$TMP_BUILD" \ | ||
| | xargs -r -n1 -P8 -I{} bash -c ' | ||
| CRD="{}" | ||
| | xargs -r -n1 -P8 bash -c ' | ||
| CRD="$1" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
deploy.sh script fails on macOS with
xargs: command line cannot be assembled, too longerror. This pull request fixes the script, specifically in how arguments are passed to thexargs-spawned bash processes.