Skip to content

Update urls#229

Merged
imnasnainaec merged 1 commit into
masterfrom
urls
Jun 11, 2026
Merged

Update urls#229
imnasnainaec merged 1 commit into
masterfrom
urls

Conversation

@imnasnainaec

@imnasnainaec imnasnainaec commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

@github-actions

Copy link
Copy Markdown

Test Results

       8 files  ±0     648 suites  ±0   8s ⏱️ ±0s
   439 tests ±0     435 ✔️ ±0      4 💤 ±0  0 ±0 
3 600 runs  ±0  3 390 ✔️ ±0  210 💤 ±0  0 ±0 

Results for commit 3fa1bb1. ± Comparison against base commit d350f67.

@ermshiperete ermshiperete left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

/// <summary>
/// Determines whether the operation resulted in an error.
/// http://icu-project.org/apiref/icu4c/utypes_8h_source.html#l00714
/// https://unicode-org.github.io/icu-docs/apidoc/released/icu4c/utypes_8h_source.html (line 816)

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could also link to https://github.com/unicode-org/icu/blob/21d1eb0f306e1141c10931e914dfc038c06121da/icu4c/source/common/unicode/utypes.h#L816 which has the line number in the link, but also more cruft. Not sure what's better.

@imnasnainaec imnasnainaec merged commit 3d97cb2 into master Jun 11, 2026
7 checks passed
@imnasnainaec imnasnainaec deleted the urls branch June 11, 2026 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants