Enable C++17 language features to satisfy libsigc++ requirements - #122
Closed
amotl wants to merge 1 commit into
Closed
Enable C++17 language features to satisfy libsigc++ requirements#122amotl wants to merge 1 commit into
amotl wants to merge 1 commit into
Conversation
When trying to build on macOS Catalina with recent compilers (GCC 10.2.0) and libraries (libsigc++ 3.0.6) installed through Homebrew, the process croaked with "error: 'invoke' is not a member of 'std'". It turned out that libsigc++ is telling us [1]: > Compatible compilers must support C++17, such as the decltype(auto) > specifier (from C++14) and std::invoke(). [1] https://github.com/libsigcplusplus/libsigcplusplus#compatibility
|
This might break the compilation on other hosts that don't have C++17, but have C++11. |
|
This has now been implemented in cbcc060 Could help if you closed the PR |
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dear Uwe, Bert, Gerhard and all other contributors,
first things first: Thanks a stack for conceiving and maintaining libsigrok.
While working on sigrokproject/sigrok-meter#1, when trying to build on macOS Catalina with recent compilers (GCC 10.2.0) and libraries (libsigc++ 3.0.6) installed through Homebrew, the process croaked with
error: 'invoke' is not a member of 'std'.It turned out that
libsigc++is telling us [1]:So, this brings in C++17 support by updating the
ax_cxx_compile_stdcxx.m4macro to the most recent version from [2] and by adjusting some bits inconfigure.ac. Please bear with me when I might have done something wrong, as C/C++ is not my native habitat. However, with those changes, GCC stopped croaking on my end.With kind regards,
Andreas.
P.S.: Others reading here also aiming at building on a recent macOS, please also note #123.
[1] https://github.com/libsigcplusplus/libsigcplusplus#compatibility
[2] http://git.savannah.gnu.org/gitweb/?p=autoconf-archive.git;a=blob_plain;f=m4/ax_cxx_compile_stdcxx.m4