Skip to content

Insert traceID in test exceptions #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
NeelkushVadalia-Signifyd wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Insert traceID in test exceptions #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions core/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,6 +184,12 @@
</exclusion>
</exclusions>
</dependency>

<dependency>
<groupId>io.opentracing</groupId>
<artifactId>opentracing-util</artifactId>
<version>0.33.0</version>
</dependency>
</dependencies>

<build>
Expand Down
10 changes: 10 additions & 0 deletions core/src/main/java/io/cucumber/core/runtime/TestCaseResultObserver.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,10 @@
import io.cucumber.plugin.event.SnippetsSuggestedEvent;
import io.cucumber.plugin.event.Status;
import io.cucumber.plugin.event.TestCaseFinished;
import io.opentracing.util.GlobalTracer;

import java.util.ArrayList;
import java.util.Arrays;
import java.util.List;
import java.util.function.Function;
import java.util.function.Supplier;
Expand Down Expand Up @@ -59,6 +61,14 @@ public void assertTestCasePassed(
return;
}
Throwable error = result.getError();

ArrayList<StackTraceElement> staketrace = new ArrayList<StackTraceElement>(
Arrays.asList(error.getStackTrace()));
staketrace.add(
new StackTraceElement("Jaeger", "Precommit",
GlobalTracer.get().activeSpan().context().toTraceId(), 0));
error.setStackTrace(staketrace.toArray(new StackTraceElement[staketrace.size()]));

if (status.is(SKIPPED) && error == null) {
Throwable throwable = testCaseSkipped.get();
throw new TestCaseFailed(throwable);
Expand Down