Skip to content

test: Fix Firefox CI hang in video spec (mock MediaStream) #255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
HTMHell merged 1 commit into from
Jun 10, 2026
Merged

test: Fix Firefox CI hang in video spec (mock MediaStream) #255

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 15 additions & 13 deletions src/app/core/modules/ngxs/store/video/video.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@ describe('VideoState', () => {
let navigatorService: NavigatorService;
let snapshot: {video: VideoStateModel};

let mockCamera: MediaStream;
let mockSettings: MediaTrackSettings;
let mockTrack: MediaStreamVideoTrack;

Expand All @@ -25,8 +24,8 @@ describe('VideoState', () => {
};
mockTrack = {
getSettings: () => mockSettings,
addEventListener: (() => {}) as any,
} as MediaStreamVideoTrack;
addEventListener: jasmine.createSpy('addEventListener'),
} as unknown as MediaStreamVideoTrack;
});

beforeEach(() => {
Expand All @@ -35,8 +34,6 @@ describe('VideoState', () => {
providers: [provideStore([VideoState], ngxsConfig), NavigatorService],
});

mockCamera = new MediaStream();

store = TestBed.inject(Store);
navigatorService = TestBed.inject(NavigatorService);
snapshot = {...store.snapshot()};
Expand Down Expand Up @@ -75,8 +72,7 @@ describe('VideoState', () => {
});

it('StartCamera error should update store', async () => {
const testError = 'testError';
const spy = spyOn(navigatorService, 'getCamera').and.throwError(new Error(testError));
const spy = spyOn(navigatorService, 'getCamera').and.throwError(new Error('testError'));

snapshot.video.error = null;
store.reset(snapshot);
Expand All @@ -86,20 +82,22 @@ describe('VideoState', () => {
expect(spy).toHaveBeenCalled();

const error = store.selectSnapshot(state => state.video.error);
expect(error).toBe(testError);
expect(error).toBe('testError');
});

it('StartCamera should get camera from navigator', async () => {
// Setup mock camera
const tracksSpy = spyOn(mockCamera, 'getVideoTracks').and.returnValue([mockTrack]);
const tracksSpy = jasmine.createSpy('getVideoTracks').and.returnValue([mockTrack]);
const mockCamera = {
getVideoTracks: tracksSpy,
getTracks: () => [] as MediaStreamTrack[],
} as unknown as MediaStream;
const cameraSpy = spyOn(navigatorService, 'getCamera').and.returnValue(Promise.resolve(mockCamera));
const listenerSpy = spyOn(mockTrack, 'addEventListener');

await firstValueFrom(store.dispatch(StartCamera));

expect(tracksSpy).toHaveBeenCalled();
expect(cameraSpy).toHaveBeenCalled();
expect(listenerSpy).toHaveBeenCalled();
expect(mockTrack.addEventListener).toHaveBeenCalled();

const {camera, error} = store.selectSnapshot(state => state.video);

Expand All @@ -108,7 +106,11 @@ describe('VideoState', () => {
});

it('StartCamera should set camera settings', async () => {
const tracksSpy = spyOn(mockCamera, 'getVideoTracks').and.returnValue([mockTrack]);
const tracksSpy = jasmine.createSpy('getVideoTracks').and.returnValue([mockTrack]);
const mockCamera = {
getVideoTracks: tracksSpy,
getTracks: () => [] as MediaStreamTrack[],
} as unknown as MediaStream;
const cameraSpy = spyOn(navigatorService, 'getCamera').and.returnValue(Promise.resolve(mockCamera));

await firstValueFrom(store.dispatch(StartCamera));
Expand Down
Loading