Skip to content

feat(popover): add docs IX-3942#245

Open
alexkaduk wants to merge 6 commits into
mainfrom
feature/IX-3942-popover
Open

feat(popover): add docs IX-3942#245
alexkaduk wants to merge 6 commits into
mainfrom
feature/IX-3942-popover

Conversation

@alexkaduk
Copy link
Copy Markdown
Collaborator

@alexkaduk alexkaduk commented May 31, 2026

💡 What is the current behavior?

The ix-popover component and its sub-components (ix-popover-header, ix-popover-image, ix-popover-content, ix-popover-footer) are available in iX, but the documentation site has no dedicated popover page. Users cannot find usage guidance, code examples, or API reference for the new component in the components section.

🆕 What is the new behavior?

  • Adds a new Popover component documentation section with Usage and Code tabs
  • Documents composition, options, behavior in context, dos and don’ts, and related components for ix-popover and its sub-components
  • Adds an interactive playground example with structure markup, methods, events, and API reference for all popover-related components
  • Registers the component in the sidebar (between Pill and Toast) and in the components overview page

Files added

File Purpose
docs/components/popover/index.mdx Tab wrapper and component description
docs/components/popover/guide.md Usage guide
docs/components/popover/code.mdx Playground, structure example, methods, events, API

Files updated

File Change
sidebars.ts Adds Popover navigation entry
docs/components/overview.md Adds Popover to the components index
.env.pullrequest Configures artifact download from ix PR 2574 for deploy previews

👨‍💻 Help & support

  • Playground preview and API sections depend on autogenerated content from the ix repo. Ensure ix PR 2574 (or a newer build that includes ix-popover-image and updated preview examples with icon registration) is merged or rebuilt before merging this PR.
  • Related component: Popover news — separate existing docs, not modified in this PR.

@netlify
Copy link
Copy Markdown

netlify Bot commented May 31, 2026

Deploy Preview for industrial-experience ready!

Name Link
🔨 Latest commit 5e44f3a
🔍 Latest deploy log https://app.netlify.com/projects/industrial-experience/deploys/6a25ad69e46f78000800cc48
😎 Deploy Preview https://deploy-preview-245--industrial-experience.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds documentation for the new Popover component, including usage guidelines, code examples, and sidebar navigation. The review feedback highlights several style guide violations in the newly added markdown files. Specifically, the feedback advises on avoiding Oxford commas, using contractions like 'don’t', framing instructions as suggestions rather than commands, using 'e.g.' instead of 'for example', and adhering to standard section headings and formatting for options, behaviors, and Dos and Don’ts.

Comment thread docs/components/popover/guide.md Outdated
Comment thread docs/components/popover/guide.md Outdated
Comment thread docs/components/popover/guide.md Outdated
Comment thread docs/components/popover/guide.md Outdated
Comment thread docs/components/popover/guide.md Outdated
Comment thread docs/components/popover/guide.md Outdated
Comment thread docs/components/popover/guide.md Outdated
Comment thread docs/components/popover/guide.md Outdated
Comment thread docs/components/popover/code.mdx Outdated
Comment thread docs/components/popover/code.mdx Outdated
@alexkaduk alexkaduk changed the title fix(popover): add docs IX-3942 feat(popover): add docs IX-3942 Jun 4, 2026
@alexkaduk alexkaduk marked this pull request as ready for review June 5, 2026 14:17
@alexkaduk
Copy link
Copy Markdown
Collaborator Author

/gemini review

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces the documentation for the new Popover component, including its overview, usage guide, code examples, and API references, and registers it in the Docusaurus sidebar. The review feedback highlights several style guide violations in the newly added documentation files, such as incorrect heading hierarchies in the code tab, the use of passive voice instead of active voice, and incorrect pluralization. Additionally, the feedback suggests reordering the sidebar entry alphabetically to maintain consistency with the overview page.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread docs/components/popover/code.mdx Outdated
Comment thread docs/components/popover/code.mdx Outdated
Comment thread docs/components/popover/code.mdx Outdated
Comment thread docs/components/popover/guide.md
Comment thread docs/components/popover/code.mdx Outdated
Comment thread sidebars.ts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant