refactor(filtered-search): focus criterion input via afterNextRender#2116
Draft
spliffone wants to merge 2 commits into
Draft
refactor(filtered-search): focus criterion input via afterNextRender#2116spliffone wants to merge 2 commits into
spliffone wants to merge 2 commits into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request improves Playwright test stability and updates Angular component lifecycle usage. Specifically, it configures Playwright to use deterministic software rendering and limits CI workers to prevent CPU saturation. It also introduces a disableAnimations option in test helpers to handle infinite animations during visual regression testing. In the Angular codebase, setTimeout is replaced with afterNextRender in SiFilteredSearchValueComponent to handle input focusing more reliably. No review comments were provided, and there is no additional feedback.
spliffone
force-pushed
the
refactor/filtered-search-edit-use-after-next-render
branch
from
c78b38e to
50e81cc
Compare
spliffone
changed the title
spliffone
force-pushed
the
refactor/filtered-search-edit-use-after-next-render
branch
from
50e81cc to
a67f03d
Compare
spliffone
force-pushed
the
refactor/filtered-search-edit-use-after-next-render
branch
2 times, most recently
from
777a2fc to
a67f03d
Compare
spliffone
force-pushed
the
refactor/filtered-search-edit-use-after-next-render
branch
from
a67f03d to
e76e6ff
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Documentation.
Examples.
Dashboards Demo.
Playwright report.
Coverage Reports: