Add Redis ACL username support for Sentinel connections#312
Merged
Conversation
Adds username support when connecting to Redis via Sentinel, enabling Redis 6.0+ ACL authentication. Uses connection_kwargs to maintain compatibility with redis>=3.2 where Sentinel does not accept username as a named argument. Fixes truthy check to `is not None` for correctness. https://claude.ai/code/session_01SZGPPwrfF3re26pXsiiuyE
sibson
force-pushed
the
claude/evaluate-redbeat-pr-7AL4M
branch
from
40e9bcb to
73e0d2a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
$(cat <<'EOF'
Summary
Based on the approach in #311, with the following improvements:
**connection_kwargs. Updated comment explains why it usesconnection_kwargs(compatibility with redis<3.4.0).is not Nonecheck: Changedif username:toif username is not None:to avoid silently ignoring an empty-string username, consistent with howpasswordis handled (passed unconditionally).assertlines with a singleassert ... == 'acl-user'which also implicitly checks key presence.Test plan
pytest tests/test_scheduler.py -k sentinel— all 8 sentinel tests passEOF
)