Skip to content

Add Popover component#51

Draft
stormwarning wants to merge 13 commits into
mainfrom
add-popover-component
Draft

Add Popover component#51
stormwarning wants to merge 13 commits into
mainfrom
add-popover-component

Conversation

@stormwarning

Copy link
Copy Markdown
Contributor

No description provided.

@changeset-bot

changeset-bot Bot commented Nov 13, 2021

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 3565961

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Comment thread addon/components/popover/trigger/index.ts Outdated

event.preventDefault();
event.stopPropagation();
closePopover();

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This internal action calls the closePopover argument function, which in turn updates the value of isOpen.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if this affects anything that you are working with right now but shouldn't this be this.args.closePopover()?

@stormwarning stormwarning Nov 22, 2021

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, it's destructured off of this.args a few lines up, but I'll see if it makes a difference...

NARRATOR: It didn't.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants