feat: add php-fpm status - #291
Merged
Merged
Conversation
Kevin Rudde (kevinrudde)
force-pushed
the
php-fpm-metrics
branch
from
July 22, 2026 14:06
705954b to
307b369
Compare
Kevin Rudde (kevinrudde)
force-pushed
the
php-fpm-metrics
branch
from
July 30, 2026 13:39
7f22aea to
2cc49a9
Compare
Kevin Rudde (kevinrudde)
marked this pull request as ready for review
July 30, 2026 13:39
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to enable Prometheus scraping of PHP-FPM metrics in OpenMetrics format by adding a dedicated Caddy handler for the PHP-FPM status endpoint, and it removes the previously auto-attached PHP-FPM exporter sidecar approach from the chart’s defaults.
Changes:
- Added a dedicated Caddy site/handler for
/-/fpm/statusthat rewrites to?openmetricsand proxies to PHP-FPM via FastCGI. - Removed the chart’s automatic injection of the
php-fpm-exportersidecar (now only user-specifiedextraContainersare rendered). - Bumped the Shopware chart version.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| charts/shopware/templates/store_caddy_config.yaml | Adds a new Caddy handler to serve PHP-FPM status in OpenMetrics format via FastCGI. |
| charts/shopware/templates/store.yaml | Removes auto-injected exporter sidecar and adds a new spec.lock block. |
| charts/shopware/values.yaml | Updates comments to indicate exporter sidecar isn’t needed (but currently conflicts with the remaining example). |
| charts/shopware/Chart.yaml | Increments chart/app version to reflect the change. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Kevin Rudde (kevinrudde)
force-pushed
the
php-fpm-metrics
branch
from
July 30, 2026 14:44
a5c77d1 to
6fcbd75
Compare
Renaud Hager (renaudhager)
approved these changes
Jul 30, 2026
Kevin Rudde (kevinrudde)
force-pushed
the
php-fpm-metrics
branch
from
July 31, 2026 10:31
f5c7cc3 to
d042b09
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds a new handler to the
store_caddy_config.yamlfile to support Prometheus scraping of PHP-FPM metrics in openmetrics format. This allows Prometheus to collect PHP-FPM status data correctly.Monitoring integration:
:9000for the/‐/fpm/statusendpoint, rewriting the path to include?openmetricsand configuring a FastCGI reverse proxy to the PHP-FPM socket, enabling Prometheus to scrape PHP-FPM metrics in the required format.