Skip to content

feat: add php-fpm status - #291

Merged
Kevin Rudde (kevinrudde) merged 7 commits into
mainfrom
php-fpm-metrics
Jul 31, 2026
Merged

feat: add php-fpm status#291
Kevin Rudde (kevinrudde) merged 7 commits into
mainfrom
php-fpm-metrics

Conversation

@kevinrudde

@kevinrudde Kevin Rudde (kevinrudde) commented Jul 22, 2026

Copy link
Copy Markdown
Member

This pull request adds a new handler to the store_caddy_config.yaml file to support Prometheus scraping of PHP-FPM metrics in openmetrics format. This allows Prometheus to collect PHP-FPM status data correctly.

Monitoring integration:

  • Added a new handler on port :9000 for the /‐/fpm/status endpoint, rewriting the path to include ?openmetrics and configuring a FastCGI reverse proxy to the PHP-FPM socket, enabling Prometheus to scrape PHP-FPM metrics in the required format.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR aims to enable Prometheus scraping of PHP-FPM metrics in OpenMetrics format by adding a dedicated Caddy handler for the PHP-FPM status endpoint, and it removes the previously auto-attached PHP-FPM exporter sidecar approach from the chart’s defaults.

Changes:

  • Added a dedicated Caddy site/handler for /-/fpm/status that rewrites to ?openmetrics and proxies to PHP-FPM via FastCGI.
  • Removed the chart’s automatic injection of the php-fpm-exporter sidecar (now only user-specified extraContainers are rendered).
  • Bumped the Shopware chart version.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

File Description
charts/shopware/templates/store_caddy_config.yaml Adds a new Caddy handler to serve PHP-FPM status in OpenMetrics format via FastCGI.
charts/shopware/templates/store.yaml Removes auto-injected exporter sidecar and adds a new spec.lock block.
charts/shopware/values.yaml Updates comments to indicate exporter sidecar isn’t needed (but currently conflicts with the remaining example).
charts/shopware/Chart.yaml Increments chart/app version to reflect the change.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread charts/shopware/templates/store.yaml
Comment thread charts/shopware/templates/store_caddy_config.yaml
Comment thread charts/shopware/values.yaml
@kevinrudde
Kevin Rudde (kevinrudde) merged commit 8bd04db into main Jul 31, 2026
3 checks passed
@kevinrudde
Kevin Rudde (kevinrudde) deleted the php-fpm-metrics branch July 31, 2026 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants