Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .npmrc

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

revert. legacy-peer-deps=true is not necessary

Original file line number Diff line number Diff line change
@@ -1 +1,2 @@
@shiftcode:registry=https://npm.pkg.github.com
legacy-peer-deps=true
21 changes: 21 additions & 0 deletions CONTEXT.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
# sc-ng-commons-public

A public Angular utility monorepo that publishes reusable libraries for Angular applications. It contains publishable libraries and a non-publishable styleguide app.

## Language

**Library**:
A publishable npm package (`@shiftcode/ngx-core`, `@shiftcode/ngx-components`) that ships Angular utilities for external consumption.
_Avoid_: Package, module, plugin

**Consumer**:
An external Angular application or library that declares one of the Libraries as a dependency.
_Avoid_: User, client, app

**Styleguide**:
The non-published Angular application in `apps/styleguide` used to develop and showcase Library features.
_Avoid_: Demo app, example app

**Angular Version Support**:
The Angular version range a given Library version declares support for, expressed via `peerDependencies`. Changing this boundary (e.g. dropping Angular 21 support) is a breaking change for Consumers.
_Avoid_: Compatibility Boundary
2 changes: 1 addition & 1 deletion apps/styleguide/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@shiftcode/styleguide",
"version": "15.2.0",
"version": "15.2.1-pr85.0",
"private": true,
"type": "module",
"scripts": {
Expand Down
5 changes: 5 additions & 0 deletions docs/adr/0001-one-angular-major-per-library-major.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
# One Angular major version per library major version

Each major version of `@shiftcode/ngx-core` and `@shiftcode/ngx-components` targets exactly one Angular major version in its `peerDependencies` (e.g. `^22.0.0`). When Angular bumps its major, the Libraries bump theirs too, and the old Angular version is dropped.

We considered keeping a dual-range like `^21.0.0 || ^22.0.0`, but this forces us to avoid any Angular 22 APIs that aren't available in Angular 21, which defeats the purpose of upgrading. A clean break keeps the maintenance surface small and makes the compatibility contract obvious to Consumers.
2 changes: 1 addition & 1 deletion lerna.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"$schema": "node_modules/lerna/schemas/lerna-schema.json",
"useNx": false,
"packages": ["libs/*", "apps/*"],
"version": "15.2.0",
"version": "15.2.1-pr85.0",
"command": {
"version": {
"allowBranch": "*",
Expand Down
14 changes: 7 additions & 7 deletions libs/components/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@shiftcode/ngx-components",
"version": "15.2.0",
"version": "15.2.1-pr85.0",
"repository": "https://github.com/shiftcode/sc-ng-commons-public",
"license": "MIT",
"author": "shiftcode GmbH <team@shiftcode.ch>",
Expand All @@ -10,12 +10,12 @@
"tslib": "^2.5.0"
},
"peerDependencies": {
"@angular/animations": "^21.0.0",
"@angular/cdk": "^21.0.0",
"@angular/common": "^21.0.0",
"@angular/core": "^21.0.0",
"@angular/forms": "^21.0.0",
"@angular/router": "^21.0.0",
"@angular/animations": "^22.0.0",
"@angular/cdk": "^22.0.0",
"@angular/common": "^22.0.0",
"@angular/core": "^22.0.0",
"@angular/forms": "^22.0.0",
"@angular/router": "^22.0.0",
"@shiftcode/logger": "^5.0.0",
"@shiftcode/ngx-core": "^15.0.0 || ^15.0.0-pr7",
"rxjs": "^6.5.3 || ^7.4.0"
Expand Down
10 changes: 5 additions & 5 deletions libs/core/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@shiftcode/ngx-core",
"version": "15.2.0",
"version": "15.2.1-pr85.0",
"repository": "https://github.com/shiftcode/sc-ng-commons-public",
"license": "MIT",
"author": "shiftcode GmbH <team@shiftcode.ch>",
Expand All @@ -10,10 +10,10 @@
"tslib": "^2.5.0"
},
"peerDependencies": {
"@angular/common": "^21.0.0",
"@angular/core": "^21.0.0",
"@angular/platform-browser": "^21.0.0",
"@angular/router": "^21.0.0",
"@angular/common": "^22.0.0",
"@angular/core": "^22.0.0",
"@angular/platform-browser": "^22.0.0",
"@angular/router": "^22.0.0",
"@shiftcode/logger": "^5.0.0",
"@shiftcode/utilities": "^5.0.0",
"rxjs": "^6.5.3 || ^7.4.0"
Expand Down
Loading
Loading