-
Notifications
You must be signed in to change notification settings - Fork 0
#85 - update to angular 22 #86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
mumenthalers
wants to merge
3
commits into
main
Choose a base branch
from
#85-update-to-angular-22
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1,2 @@ | ||
| @shiftcode:registry=https://npm.pkg.github.com | ||
| legacy-peer-deps=true |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| # sc-ng-commons-public | ||
|
|
||
| A public Angular utility monorepo that publishes reusable libraries for Angular applications. It contains publishable libraries and a non-publishable styleguide app. | ||
|
|
||
| ## Language | ||
|
|
||
| **Library**: | ||
| A publishable npm package (`@shiftcode/ngx-core`, `@shiftcode/ngx-components`) that ships Angular utilities for external consumption. | ||
| _Avoid_: Package, module, plugin | ||
|
|
||
| **Consumer**: | ||
| An external Angular application or library that declares one of the Libraries as a dependency. | ||
| _Avoid_: User, client, app | ||
|
|
||
| **Styleguide**: | ||
| The non-published Angular application in `apps/styleguide` used to develop and showcase Library features. | ||
| _Avoid_: Demo app, example app | ||
|
|
||
| **Angular Version Support**: | ||
| The Angular version range a given Library version declares support for, expressed via `peerDependencies`. Changing this boundary (e.g. dropping Angular 21 support) is a breaking change for Consumers. | ||
| _Avoid_: Compatibility Boundary |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| # One Angular major version per library major version | ||
|
|
||
| Each major version of `@shiftcode/ngx-core` and `@shiftcode/ngx-components` targets exactly one Angular major version in its `peerDependencies` (e.g. `^22.0.0`). When Angular bumps its major, the Libraries bump theirs too, and the old Angular version is dropped. | ||
|
|
||
| We considered keeping a dual-range like `^21.0.0 || ^22.0.0`, but this forces us to avoid any Angular 22 APIs that aren't available in Angular 21, which defeats the purpose of upgrading. A clean break keeps the maintenance surface small and makes the compatibility contract obvious to Consumers. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
revert.
legacy-peer-deps=trueis not necessary