Added a simplifying function using double ended deque that can run in linear time#3
Open
z1w wants to merge 6 commits into
Open
Added a simplifying function using double ended deque that can run in linear time#3z1w wants to merge 6 commits into
z1w wants to merge 6 commits into
Conversation
… in linear time and easy to maintain; also added a unit test for this function
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new
simplify_relator_with_dequefunction utilizing a deque-based approach for relator simplification. The implementation achieves inverse pair elimination in O(n) time complexity and provides robust handling of cyclical eliminations. This function also returns the count of non-zero elements in the simplified relator, serving as an invariant for the simplification process.A comprehensive unit test
test_simplify_dequeis also provided.