feat: allow parseInt(id, 10) without magic number extraction#3
Merged
Conversation
Adds 10 to llm-core/no-magic-numbers ignore list so the standard decimal radix in parseInt() doesn't force a named constant extraction. Adds parseNumericId() test functions to test.js, test.ts, and test.tsx to verify the literal 10 radix passes lint in all configurations.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
10to thellm-core/no-magic-numbersignore list so the standard decimal radix inparseInt()no longer forces a named constant extraction likeDECIMAL_RADIX.Changes
es6/index.js— Added10to the ignore array:[0, 1, 2, 3, 4, 5, 10, 12, 15, 120]test/test.js,test/test.ts,test/test.tsx— AddedparseNumericId()functions usingparseInt(id, 10)to verify the literal radix passes lint in JS, TS, and React configurationspackage.json— Version bumped from8.0.0to8.1.0CHANGELOG.md— Added8.1.0entryVerification
Self-test passes:
npm test— zero errors, zero warnings.