fix: execute carve commands from explicit argv - #74
Merged
Conversation
- Add one validated JSON argv parser, display formatter, and direct executor - Migrate test and database command surfaces away from implicit shell parsing - Fail legacy command strings with migration guidance before branch mutation - Document explicit shell invocation and cover the safety boundary in tests - Prevent repository-controlled command text from gaining unintended shell semantics - Preserve intentional pipelines and redirection through an explicit `sh -lc` argv - Improve the security scan findings without removing workflow functionality
This was referenced Jul 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR
Replace implicit shell parsing in
carve-changesetswith validated explicit argv while preserving intentional shell workflows.Summary
Validation
just formatjust lintjust testTickets
Refs #71