Skip to content

Add review-code-simplicity skill - #15

Merged
shaug merged 1 commit into
mainfrom
scott/issue-8-code-simplicity
Jul 20, 2026
Merged

Add review-code-simplicity skill#15
shaug merged 1 commit into
mainfrom
scott/issue-8-code-simplicity

Conversation

@shaug

@shaug shaug commented Jul 20, 2026

Copy link
Copy Markdown
Owner

TL;DR

Adds a local code-simplicity review skill that reduces duplicated policy, unnecessary control flow, and cognitive load without redesigning the solution.

Summary

  • Introduces the standalone review-code-simplicity skill and a repository-reuse and cognitive-load rubric.
  • Requires concrete, behavior-preserving simplifications with measurable reductions in policies, passes, states, call depth, or setup.
  • Rejects wrappers and abstractions that only relocate complexity, while preserving explicit tests for distinct invariants.
  • Adds packet and standalone evaluations for shared policy, one-pass processing, pass-through indirection, test setup, security cases, and clean changes.
  • Defines the net-cost evidence required before recommending existing or new dependencies and documents the new skill.

Validation

  • Repository formatting, linting, skill validation, and all test gates pass.
  • Fresh forward evaluations found every seeded simplification and rejected mechanical DRY and style-only feedback.
  • An independent final review found no material ticket-scoped issues at the published head.

Tickets

Fixes #8

## Summary

- Add a standalone read-only code-simplicity skill with a repository-reuse and cognitive-load rubric
- Add policy reuse, one-pass flow, wrapper, test setup, explicit-security-test, and clean evaluations
- Prove standalone raw-evidence review and document the skill

## Why

- Reduce duplicated policy, unnecessary phases, pass-through indirection, and irrelevant setup without redesigning the solution
- Reject mechanical DRY and abstractions that only relocate complexity
@shaug
shaug merged commit 1bd9882 into main Jul 20, 2026
1 check passed
@shaug
shaug deleted the scott/issue-8-code-simplicity branch July 20, 2026 04:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add the review-code-simplicity skill

1 participant