Skip to content

Add goal-first review-correctness skill - #13

Merged
shaug merged 1 commit into
mainfrom
scott/issue-6-review-correctness
Jul 20, 2026
Merged

Add goal-first review-correctness skill#13
shaug merged 1 commit into
mainfrom
scott/issue-6-review-correctness

Conversation

@shaug

@shaug shaug commented Jul 20, 2026

Copy link
Copy Markdown
Owner

TL;DR

Adds a repository-owned, goal-first correctness review skill that finds material failures without depending on third-party review skills.

Summary

  • Introduces the standalone review-correctness skill and a focused rubric for requirements, security, behavior, compatibility, validation, and material performance risks.
  • Grounds findings in the ticket and the reviewed repository's own rules before applying generic guidance.
  • Uses the shared review packet and result contracts while preserving strict read-only review behavior.
  • Adds raw authorization, missing-test, repository-convention, and standalone ticket-reconstruction evaluations.
  • Documents the new skill in the repository catalog and changelog.

Validation

  • Repository formatting, linting, skill validation, and test gates pass.
  • Fresh forward evaluations found seeded material failures, rejected a clean convention-following change, and reconstructed intent from raw ticket and repository evidence.
  • An independent final review found no material ticket-scoped issues at the published head.

Tickets

Fixes #6

## Summary

- Add a standalone read-only correctness review skill with a focused rubric and shared-contract output
- Add raw authorization, missing-test, and repository-convention fixtures
- Add contract tests and validate the skill through clean-context forward tests

## Why

- Provide repository-owned correctness, security, compatibility, and validation review without a third-party runtime dependency
- Ground findings in ticket intent and local repository evidence before generic advice
@shaug
shaug merged commit 8e85732 into main Jul 20, 2026
1 check passed
@shaug
shaug deleted the scott/issue-6-review-correctness branch July 20, 2026 03:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add the goal-first review-correctness skill

1 participant