feat: define shared code review contracts - #12
Merged
Conversation
## Summary - Add canonical review packet and result schemas with a dependency-free validator - Add raw evaluation fixtures for correctness, simplicity, necessary complexity, missing evidence, and base drift - Wire contract tests into the repository validation workflow ## Why - Give every repository-owned review lens one executable evidence, finding, and verdict contract - Prevent downstream skills from inventing incompatible schemas or leaking expected answers into forward tests
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR
Adds the executable shared evidence, finding, verdict, and fixture contracts that every repository-owned code-review skill will consume.
Summary
This establishes a non-discoverable
review-suite/foundation rather than publishing an incomplete skill. It defines canonical JSON schemas and cross-field semantics for review packets and results, including candidate identity, required focused and full validation evidence, material finding classifications, blocked-review behavior, and risk-based base-drift retention.A dependency-free validator checks structural and semantic conformance, candidate/result identity, contradictory verdicts, malformed packets, and the distinction between missing evidence and invalid input. Raw forward-test fixtures keep reviewer prompts separate from expected outcomes and cover correctness failures, duplicated policy, imagined machinery, necessary concurrency complexity, clean changes, missing evidence, and unrelated base drift. Every fixture diff is verified as a parseable patch.
The foundation intentionally does not implement a discoverable review lens or orchestration behavior; those remain owned by the dependent epic children.
Validation
just formatjust lintjust test(41 existing tests and 24 review-contract tests)git diff --checkTickets
Fixes #5