tree-ops optimizations for large trees#90
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some optimizations for large trees and slow disks:
regex_rewrite_treewhich powersmvandcp) to avoid excessive copying.pathandPathto drastically reduce the amount of allocations from concatenating strings.paralleldepthandfollow_symlinksto FileTree constructor.I realized that the pre-walkdir implementation actually followed symlinks by default, and walkdir has
follow_symlinksset to false as default which technically made that commit breaking. Defaulting it totruefixes that breakage. Also, contrary to the intuition,follow_symlinks=trueis actually the faster option as when set to false it causes walkdir to stat each directory to test if it a symlink (which is not a huge cost since this generally does not touch the filesystem, but still).mvspeedup example:0.4.3 (after warmup):
This PR (after warmup):
FileTreector example:@ghyatzo: This might be interesting for you.