Fixes variable names and corrects handling of inputs/outputs for emit… - #1
Open
dylanmkennedy wants to merge 111 commits into
Open
Fixes variable names and corrects handling of inputs/outputs for emit…#1dylanmkennedy wants to merge 111 commits into
dylanmkennedy wants to merge 111 commits into
Conversation
- Subclass wire and profile monitor classes
* Changes to support NC wire scans * Create BPM objects in a safer way. Pad data from BSA buffer to avoid index mismatches. Add "DOG" to valid regions. * Added maximum number of pads. * Edited FitResult to accept DetectorFit. Adjust WBPMR to reflect Fit changes. Made RMS sizes optional for case of single plane scans. * Imported new DetectorFit class. Refactored fit result collation. Added checks on rms_sizes for single plane scans. * Concatenate bpm_data and padding. * Linting fixes. * More linting... * Changing to detectors from lblms * Separated out starting timing buffer into new function. Separated out helper functions. Collecting buffer data with size check. Fixed creator methods for detectors. Added docstrings. * Linting * pv_cache linting error * Un-nest helper functions. Move RMS sizes out to own function. * Undefined variable fix. * Created class attribute 'detectors'. Moved buffer release to end of .measure(). Replace references to BSA with buffer. * Confirm area is NC beampath before appending global beam rate PV * Added collect_with_size_check function * Uses collect_with_size_check() from utils * Removed unused import. * Add logger calls. * Add logger to collect_with_size_check calls * Reorder collect_with_size_check args * Refactored rms_sizes for emittance reconstruction expected results * Linting. --------- Co-authored-by: Tyler Kabana <kabanaty@dev-srv09.slac.stanford.edu>
…tance calculation.
…aclab#333) - Delete superconducting device classes and utilities - Delete magnet frontend widget - Remove corresponding unit tests
… Removing unnecessary ValidationError.
…ation failure during detector creation.
Add support for slow wire scans and DIAG0 configuration
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…tance calculation.