fix: skip signature sidecars (.asc/.sig/.pem) in asset scoring#8
Merged
Conversation
Repos like helm publish ONLY detached signature files on their GitHub releases (helm-...-linux-amd64.tar.gz.asc) and host the real binaries elsewhere (get.helm.sh). score_asset's skip list was narrower than the fallback exclusion in pick_asset, so gri scored the .asc as a binary, failed the archive-extension case, and copied a PGP signature to /usr/local/bin/helm. Align score_asset's skip list with pick_asset's intent by excluding .asc/.sig/.pem. For repos that ship both an archive and its signature the real archive already outscores the sidecar, so this only changes behaviour when no real binary exists — turning a broken install into a clear "no asset matched" error. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Repos like helm publish ONLY detached signature files on their GitHub releases (helm-...-linux-amd64.tar.gz.asc) and host the real binaries elsewhere (get.helm.sh). score_asset's skip list was narrower than the fallback exclusion in pick_asset, so gri scored the .asc as a binary, failed the archive-extension case, and copied a PGP signature to /usr/local/bin/helm.
Align score_asset's skip list with pick_asset's intent by excluding .asc/.sig/.pem. For repos that ship both an archive and its signature the real archive already outscores the sidecar, so this only changes behaviour when no real binary exists — turning a broken install into a clear "no asset matched" error.