security: fail by default when no checksum found, add --allow-missing-checksum flag#5
Merged
Conversation
Previously gri would print a warning and continue installing when a release published no checksum file. This is a silent security downgrade that the user never explicitly consented to. New behaviour: abort with an error if no checksum asset is found. The new --no-verify / -k flag opts out explicitly, making the intent visible and intentional rather than silent. Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Motivation
The previous warning-only path was a silent security downgrade: a compromised CDN or a MITM attack would land exactly here, and gri would
install the tampered binary without complaint. The user had no way to express intent either way.
Making it a hard error forces an explicit decision. The flag name --allow-missing-checksum was chosen over --no-verify because the behaviour
is scoped: it only tolerates an absent checksum file — if a checksum is found, it is always verified regardless of the flag.
Behaviour change
Before
warning: no checksum file found in release assets, skipping verification
installed to /opt/kube-linter/v0.8.3
After (no flag)
error: no checksum file found in release assets
→ use --allow-missing-checksum to install without verification
After (--allow-missing-checksum)
warning: --allow-missing-checksum set, proceeding without verification
installed to /opt/kube-linter/v0.8.3
Test plan