Skip to content

WMO Instruments Part 3: Rename enhancement and composite YAML files#5

Open
sfinkens wants to merge 13 commits into
wmo-instruments-part1from
wmo-instruments-part3-rename
Open

WMO Instruments Part 3: Rename enhancement and composite YAML files#5
sfinkens wants to merge 13 commits into
wmo-instruments-part1from
wmo-instruments-part3-rename

Conversation

@sfinkens

Copy link
Copy Markdown
Owner

Rename enhancement/composite YAML files so that they follow the WMO instrument naming convention. To be merged into pytroll#3390 .

Composites

The following composite files were renamed

insat3d_img -> imager_insat
vii         -> metimage
ec_msi      -> msi
msu-gsa     -> msu-gs-a
virr        -> virr_fy-3
sar-c       -> sar-c_sentinel-1
sen2_msi    -> msi_sentinel-2a

The following composite files are new and only load the corresponding shared composite.

imager_goes_8-11  -> goes_imager
imager_goes_12-15 -> goes_imager
mwr_aws           -> mwr
mwr_sterna        -> mwr
oli               -> oli_tirs
tirs              -> oli_tirs

Enhancements

The following enhancement files were renamed:

sen2_msi -> msi

The following symbolic links are new and only point to the shared enhancement (there is no mechanism like the dependency tree for enhancements)

mrw_sterna.yaml -> mwr.yaml
mwr_aws.yaml    -> mwr.yaml

Compatibility

Also search for user-defined composites and enhancements with the old instrument name. If present, display a deprecation warning asking users to rename their files.

@sfinkens sfinkens changed the base branch from main to wmo-instruments-part1 June 29, 2026 16:20
@sfinkens sfinkens closed this Jun 29, 2026
@sfinkens sfinkens reopened this Jun 29, 2026
@coveralls

Copy link
Copy Markdown

Coverage Report for CI Build 28388350757

Coverage increased (+0.006%) to 96.44%

Details

  • Coverage increased (+0.006%) from the base build.
  • Patch coverage: No coverable lines changed in this PR.
  • 5 coverage regressions across 2 files.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

5 previously-covered lines in 2 files lost coverage.

File Lines Losing Coverage Coverage
enhancements/enhancer.py 4 92.06%
readers/mwr_l1b.py 1 98.92%

Coverage Stats

Coverage Status
Relevant Lines: 59330
Covered Lines: 57218
Line Coverage: 96.44%
Coverage Strength: 3.84 hits per line

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants