Refresh CLI example flag metadata and fix Feature prop usage#15
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR
Updated the CLI example to keep the temporary search flag metadata current and aligned the example app with the
Featurecomponent'sflagprop.What changed?
search-platformfallback flag expiration inpackages/cli/examples/flags.jsonnameprop withflagonFeatureinpackages/cli/examples/src/App.tsxHow to test?
Featurewrapper gates the Dashboard v2 link usingflag="dashboardV2"Why make this change?
Need help on this PR? Tag
@codesmithwith what you need. Autofix is disabled.Note
Low Risk
Example-only changes to flag metadata and a prop rename; no runtime product or security impact.
Overview
Updates the CLI example so it matches the current
@latchflags/reactAPI and keeps sample flag metadata current.In
packages/cli/examples/src/App.tsx, theFeaturewrapper now usesflag="dashboardV2"instead of the invalidnameprop, consistent with documented usage elsewhere in the repo.In
packages/cli/examples/flags.json,legacySearch.expiresAtis pushed from 2026-01-15 to 2027-01-15 for the temporary search fallback flag.Reviewed by Cursor Bugbot for commit c8f686f. Bugbot is set up for automated code reviews on this repo. Configure here.