Notify client state subscribers on loading transitions#14
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR
Notify
subscribeToClientState()listeners whenload()andreload()enterloading, while keeping flag-value subscriptions unchanged.What changed?
subscribe()andsubscribeToFlag()behavior so they still only fire on effective flag value changesHow to test?
subscribeToClientState()seesloadingbefore the fetch resolvesWhy make this change?
Need help on this PR? Tag
@codesmithwith what you need. Autofix is disabled.Note
Low Risk
Narrow subscription-behavior change in core with tests; no auth or data-path changes, though devtools or inspection UIs may see extra client-state callbacks.
Overview
load()/reload()now emitsubscribeToClientState()callbacks as soon as status becomes"loading", not only when the fetch finishes or errors.subscribe()andsubscribeToFlag()are unchanged and still run only when effective flag values change.AGENTS.md documents this split. Core tests add a regression case for the in-flight
loadingnotification and update an existing client-state notification count.Reviewed by Cursor Bugbot for commit 03575d0. Bugbot is set up for automated code reviews on this repo. Configure here.