feat!: raise FetchError instead of silently falling back#17
Merged
Conversation
Providers no longer silently swallow exceptions and return a default John 3:16 verse. All fetch/parse errors now raise Votd::FetchError with the original exception preserved as #cause. Adds Votd.logger and Votd.on_error callback for observability, letting users integrate with standard logging or error trackers like Sentry. Closes #12
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Votd::FetchErrorinstead of silently returning a default John 3:16 verse when fetch/parse failsVotd.loggerfor standard Ruby logging of provider errorsVotd.on_errorcallback for error tracker integration (Sentry, Honeybadger, etc.)FetchError#causefor debuggingFetchErrorwith user-friendly error outputBreaking change
All provider errors now raise
Votd::FetchErrorinstead of falling back to defaults. Users must rescue errors explicitly:Test plan
bundle exec ruby bin/smoke_testagainst live APIsbin/votd versehappy pathbin/votd versewith network disconnected (should show error)Closes #12