feat!: Build proper CLI with Thor#15
Closed
steveclarke wants to merge 2 commits into
Closed
Conversation
Replace the bare stub CLI with a Thor-based CLI supporting provider selection, Bible translation, and output format options. Breaking change: `votd` no longer fetches a verse by default. Use `votd verse` instead, with optional --provider, --translation, and --format flags. Closes #13
Member
Author
|
Merged to master manually. Included in v4.0.0 release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
bin/votdwith a Thor-based CLIvotd versecommand with--provider,--translation, and--formatoptionsvotd versioncommandthoras a runtime dependencyBreaking change:
votdalone now shows help instead of fetching a verse. Usevotd verseinstead.Test plan
votd verse— default BibleGateway NIV text outputvotd verse -p netbible/-p ourmanna— provider selectionvotd verse --translation kjv— BibleGateway translationvotd verse -f html/-f json— output formatsvotd verse --help— shows optionsvotd help— shows command listvotd version— shows gem versionCloses #13