gRPC endpoints added on v2#39
Closed
setavenger wants to merge 12 commits into
Closed
Conversation
We are now using the proper cmd, internal, pkg structure. The fucntions and information flow within the program will still need to be overhauled.
Redesigned to have byte slices/arrays instead of strings for almost all relevant fields
- Might have to fix some naming conventons - This will also greatly benefit from general type clean up - benchmarking incoming
Owner
Author
|
superseded by #48 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First step for a major overhaul. This PR introduces gRPC endpoints and streaming which promises great improvements for both bandwidth and transfer speeds.
The code has also been refactored a lot. We removed the src/ directory and moved to a more idiomatic directory layout. Many common representations like txids, pubkeys and block-hashes have been modified to use byte slices/arrays instead of strings, which were partly used due to the way we received the data from the nodes.
The database structure will still need an overhaul. As not all string types have been replaced by bytes there's still some work to do but those endeavors are closely linked.