fix(windows): ship Authenticode-signed installer to users#55
Merged
Conversation
The signing pipeline merged in #54 only runs on tagged releases. Bumping to 1.11.2 so existing 1.11.x WinSparkle clients pull a Servmask Inc.-signed installer and replace the unsigned binary currently installed on disk. No code change in this commit; release-please picks up the fix: prefix and opens a Release PR for 1.11.2.
Contributor
Build Artifacts
Built from 9d96db3. Artifacts expire after 90 days. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Empty
fix:commit to bump Traktor from 1.11.1 to 1.11.2 so release-please cuts a new release that exercises the SSL.com eSigner pipeline merged in #54.Why
The #54 merge added Authenticode signing to release.yml but, as a
ci:commit, didn't trigger a version bump. Existing 1.11.x WinSparkle clients won't see a new update until master gets afeat:orfix:commit that release-please treats as bump-worthy. Rather than wait for incidental work to land, this commit explicitly bumps so signing reaches users now.Test plan
Servmask Inc.as signer.