Refactorization: introduce parameter groups - phase I#138
Open
trinetra75 wants to merge 21 commits into
Open
Conversation
The class package all execution paraemters shared across the library Also added minor utilities to retrieve the class from legacy parameters and to handle the execution state
Added second overload tha accepts a ExecutionOption class
Now it forwards non locally used parameters to the proceedToCoex sub-call.
Updated internal calls and tests to the new overload.
Updated internal calls and tests
Move examples and vignettes to use the new parameter
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduced a new parameters' group: ExecutionOptions,
It includes:
cores,optimizeForSpeed,deviceStrandchunkSize.Backward compatibility is maintained: at later stage
lifecyclewill be introduced to phase out legacy parameters.