✨ Voting Portal: Voter Facing Text Improvements#2594
Conversation
|
Thank you for your contribution! Before we can merge this PR, we need you to sign our Contributor License Agreement (CLA). To sign the CLA, please comment on this PR with: I have read the CLA Document and I hereby sign the CLA Guy Zilber seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. |
There was a problem hiding this comment.
Pull request overview
This PR updates English voter-facing copy in the Voting Portal and adds new English translations for ballot encoding/validation errors.
Changes:
- Refines wording across multiple voting flow screens (start/review/confirmation/audit, ballot locator).
- Adjusts several translation keys/values (including footer and common labels).
- Adds a new
translations.errors.{encoding,implicit,explicit}section with additional error strings.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| }, | ||
| footer: { | ||
| poweredBy: "Powered by <1></1>", | ||
| poweredBy: "Powered by <sequent />", |
| @@ -69,91 +56,91 @@ | |||
| descriptionNoAudit: | |||
| "To make changes in your selections, click “<b>Edit ballot</b>” button, to confirm your selections, click “<b>Cast your ballot</b>” button below.", | |||
| backButton: "Edit ballot", | |||
| castBallotButton: "Cast your ballot", | |||
| castBallotButton: "Submit ballot", | |||
| auditButton: "Audit ballot", | |||
There was a problem hiding this comment.
Reverted terminology to "Cast"
| writeInChoiceOutOfRange: "Write-in choice out of range: {{index}}", | ||
| writeInNotEndInZero: "Write-in doesn't end on 0", | ||
| writeInCharsExceeded: | ||
| "Write-in exceed by {{numCharsExceeded}} the maximum number of chars. Requires fixing.", |
| goBack: "Go back", | ||
| showMore: "Show More", | ||
| showLess: "Show Less", | ||
| goBack: "Back", |
| title: "Information: Ballot screen", | ||
| title: "About this screen", | ||
| content: | ||
| "This screen shows the contest you are elegible to vote. You can make your section by activate the checkbox on the Candidate/Answer right. To reset your selections, click “<b>Clear selection</b>” button, to move to next step, click “<b>Next</b>” button below.", |
| }, | ||
| }, | ||
| errors: { | ||
| encoding: { |
There was a problem hiding this comment.
as you're adding new fields here, you'll also need to add them to the other translations as en.ts defines the type.
There was a problem hiding this comment.
Isn't this done automatically by i18? Do I need to manually translate and add this?
| @@ -1,66 +1,53 @@ | |||
| // SPDX-FileCopyrightText: 2025 Sequent Tech Inc <legal@sequentech.io> | |||
| // SPDX-FileCopyrightText: 2022 Félix Robles <felix@sequentech.io> | |||
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Added showmore/showless per copilot suggestions
Modified footer to include arguments instead of hardcoded "Sequent"
fixed typo: elegeble -> eligible
Added question mark following: Are you sure you want to submit your vote
reverted "submit" terminology to "cast" terminology
fixed grammatical issues with write in exceeded error
added missing cert errors
Added missing ballot locator errors
added back missing ballot locator fields
| ok: "Review selection", | ||
| continue: "Continue", | ||
| cancel: "Cancel", | ||
| }, |
There was a problem hiding this comment.
@GuyZequent warningDialog is removed from the file but not from the code, I guess this was not intended, shall I put it back?
There was a problem hiding this comment.
Yes, that's a mistake on my part
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 8 out of 8 changed files in this pull request and generated 10 comments.
Comments suppressed due to low confidence (1)
packages/voting-portal/src/translations/en.ts:95
- This dialog title is missing a question mark, but it’s phrased as a question. Please add
?to keep punctuation consistent with other dialog titles.
auditBallotHelpDialog: {
title: "Would you like to audit your ballot",
content:
"<p>Auditing your ballot will void it and restart the voting process. Continue only if you’re comfortable with the advanced steps. Otherwise, click <u>Cancel</u> to go back.</p>",
| }, | ||
| footer: { | ||
| poweredBy: "Powered by <1></1>", | ||
| poweredBy: "Powered by <0></0>", |
| }, | ||
| footer: { | ||
| poweredBy: "Funciona con <1></1>", | ||
| poweredBy: "Funciona con <0></0>", |
| }, | ||
| footer: { | ||
| poweredBy: "Funciona amb <1></1>", | ||
| poweredBy: "Funciona amb <0></0>", |
| }, | ||
| footer: { | ||
| poweredBy: "Propulsé par <1></1>", | ||
| poweredBy: "Propulsé par <0></0>", |
| }, | ||
| footer: { | ||
| poweredBy: "Aangedreven door <1></1>", | ||
| poweredBy: "Aangedreven door <0></0>", |
| }, | ||
| footer: { | ||
| poweredBy: "Desenvolvido por <1></1>", | ||
| poweredBy: "Desenvolvido por <0></0>", |
| }, | ||
| footer: { | ||
| poweredBy: "Honek bultzatuta: <1></1>", | ||
| poweredBy: "Honek bultzatuta: <0></0>", |
| }, | ||
| footer: { | ||
| poweredBy: "Pinapagana ng <1></1>", | ||
| poweredBy: "Pinapagana ng <0></0>", |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Parent Issue: https://github.com/sequentech/meta/issues/11924