perf: splat performance mode (key 'p') + perf-smoke regression guard#21
Merged
Conversation
#1 Splat performance mode: press 'p' to cap splats loaded (maxSplats=1.5M) and reload the current scene in place; bounds GPU render cost on multi-million-splat captures. Measured devils-tower (3.4M): 13.7 -> 18.2 fps (+33%) with the cap. Opt-in (full quality by default). #10 scripts/perf-smoke.mjs: a Playwright frame-time regression guard (empty / light splat / splat+feeds FPS floors) — the harness used to find the lag and verify the round-robin + auto-frame + perf-mode fixes. #8 detection under round-robin: verified no fix needed — exportCameraFeed reads the persisted (round-robin-rendered) target, so per-camera detection degrades gracefully to ~12/N fps on valid pixels. tsc passes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two follow-ups to the lag work (plan steps #1 + #10; #8 verified no-op).
#1 Splat performance mode (key
p)Toggle to cap splats loaded (
maxSplats = 1.5M) and reload the current scene in place — bounds GPU render cost on multi-million-splat captures (render scales with splat count / overdraw). Opt-in; full quality by default.Measured (devils-tower, 3.4M): 13.7 → 18.2 fps (+33%) with the cap.
#10 Perf-regression guard (
scripts/perf-smoke.mjs)The Playwright frame-time harness used throughout this work, codified: measures FPS across empty / light-splat / splat+feeds and fails below documented floors. Run with a live dev server +
npx playwright install chromium. (CI wiring is a follow-up — needs the dev dep + a job.)#8 Detection under round-robin — verified, no fix
exportCameraFeedonly reads the (round-robin-rendered) render target, so per-camera detection degrades gracefully to ~12/N fps on valid pixels.tscpasses.