ci: make main CI green (fmt, ts-behavior invocation, quinn advisory)#16
Merged
Conversation
Three non-behavioral fixes that close the three red CI jobs. No protocol/wire or runtime-logic changes. 1. fmt + clippy + test (was: Format check failed): run rustfmt (toolchain 1.88.0) over four pre-existing unformatted files — bus.rs, transport.rs, ncp-zenoh/src/lib.rs, ncp-zenoh/tests/safety_governor_over_wire.rs. Whitespace only (method-chain wrapping). clippy -D warnings already clean. 2. ts dist up-to-date (was: 'TS behavioral conformance' failed): CI runs 'bun run check:behavior' from the repo root, but that script lived only in ncp-ts/package.json, so bun reported 'Script not found'. The check itself passes (18 vectors match). Add check:behavior to the root package.json, next to the other root-relative ncp-ts/scripts/*.mjs scripts (sync/build/regen). 3. cargo-deny (was: advisories FAILED): bump quinn-proto 0.11.14 -> 0.11.15 (Cargo.lock only) to clear the memory-exhaustion advisory pulled in transitively via zenoh -> quinn. 'cargo deny check advisories' now ok. Verified locally (toolchain 1.88.0): cargo fmt --all --check clean; cargo clippy --all-targets --all-features -D warnings clean; bun run check:behavior ok; cargo deny check advisories ok; ncp-ts/dist unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes the three red jobs on
mainCI. All three fixes are non-behavioral — no protocol/wire or runtime-logic changes.fmt + clippy + testFormat checkfailed on 4 pre-existing unformatted filescargo fmt --all(toolchain 1.88.0) — whitespace/method-chain wrapping onlyts dist up-to-datebun run check:behaviorfrom repo root, but the script lived only inncp-ts/package.json→Script not foundcheck:behaviorto rootpackage.json(alongside the other root-relativencp-ts/scripts/*.mjsscripts). The check itself already passes (18 vectors match).cargo-denyadvisories FAILED—quinn-proto 0.11.14memory-exhaustion advisory (transitive viazenoh → quinn)cargo update -p quinn-proto→ 0.11.15 (Cargo.lock only)Verified locally (toolchain 1.88.0)
cargo fmt --all --check— cleancargo clippy --all-targets --all-features -- -D warnings— cleanbun run check:behavior—18 vectors matchcargo deny check advisories—advisories okncp-ts/dist— unchanged (no drift)Scope / safety
No changes to
proto/ncp.proto, the JSON wire, schemas, or any decision logic. The fmt diff is whitespace; the package.json change adds one script; the Cargo.lock change is a patch-level transitive bump to a security-fixed version. Nothing here touches downstream consumers' wire contract (still v0.5.2).