Fix race condition NullPointerException in EmpowerPlantActivity (ANDROID-EH)#230
Draft
cursor[bot] wants to merge 1 commit into
Draft
Fix race condition NullPointerException in EmpowerPlantActivity (ANDROID-EH)#230cursor[bot] wants to merge 1 commit into
cursor[bot] wants to merge 1 commit into
Conversation
Fixes ANDROID-EH Add null check in onResume() database observer callback before calling textCartItemCount.setText(). This prevents a NullPointerException when the callback fires before onCreateOptionsMenu() has initialized the textCartItemCount view. The race condition occurred because: - onResume() subscribes to a database observer that updates textCartItemCount - onCreateOptionsMenu() initializes textCartItemCount - onCreateOptionsMenu() can be invoked after onResume(), creating a window where the callback fires with a null textCartItemCount reference
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #230 +/- ##
=====================================
Coverage 0.00% 0.00%
=====================================
Files 16 16
Lines 875 877 +2
Branches 65 65
=====================================
- Misses 875 877 +2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes ANDROID-EH
This PR fixes a race condition that causes a
NullPointerExceptionwhen a database observer's callback fires inonResume()beforeonCreateOptionsMenu()has initialized thetextCartItemCountview.Root Cause
The race condition occurred due to the following sequence:
textCartItemCount.setText()throws aNullPointerExceptionbecausetextCartItemCountis nulltextCartItemCountis null because the database observer callback fires before it is initializedonCreateOptionsMenu()onCreateOptionsMenu()is invoked independently of the activity lifecycleonResume(), creating a race conditionSolution
Added a null check in the
onResume()database observer callback before callingtextCartItemCount.setText(). This prevents theNullPointerExceptionwhen the callback fires before the view has been initialized.Changes
EmpowerPlantActivity.javato add a null safety check:if (textCartItemCount != null)guard before updating the textTesting
The fix ensures that:
EmpowerPlantActivitywithout crashing