Fix ArithmeticException crash on div_zero button tap#229
Open
sentry[bot] wants to merge 1 commit into
Open
Conversation
The div_zero button's click listener contained a hardcoded 'int t = 5 / 0' that threw an unhandled ArithmeticException, crashing the app. Wrap the division in a try-catch and report the exception to Sentry instead. Fixes ANDROID-HX
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #229 +/- ##
=====================================
Coverage 0.00% 0.00%
=====================================
Files 16 16
Lines 875 878 +3
Branches 65 65
=====================================
- Misses 875 878 +3 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
div_zerobutton's click listener inMainActivity.javacontained a hardcodedint t = 5 / 0that threw an unhandledArithmeticException, crashing the app every time the button was tapped.Fix
Wrapped the division in a
try-catch(ArithmeticException)block and report the exception to Sentry viaSentry.captureException(e), consistent with the existing handled-exception pattern used elsewhere in the same file.How to verify
com.example.vu.android).MainActivity.Fixes ANDROID-HX