chore: merge develop into main - #163
Closed
danielewood with Copilot wants to merge 1 commit into
Closed
Conversation
Copilot
AI
changed the title
[WIP] Merge develop branch into main for improvements
chore: merge develop into main
Mar 10, 2026
Collaborator
|
Superseded by #166 and subsequent develop updates. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Promotes the develop branch into main, bringing robustness improvements to SQLite publish atomicity, AIA chain resolution, MemStore concurrency safety, and WASM export UX.
SQLite atomic publish (
internal/certstore/sqlite.go)slog.Warninstead of silently discarded (ERR-5)os.ErrExistreturned only for true concurrent-write races; re-save to existing path works correctlyWASM export (
cmd/wasm/main.go)DefaultExportPasswordWarningwithwasmDefaultExportPasswordWarning— directs browser callers to pass a password tocertkitExportBundlesrather than referencing--passwords/--password-fileflagsAIA / chain resolution
ResolveAIAreturnsResolveAIAResult(structured:Warnings,FetchedCount,Incomplete,UnresolvedCount) instead of a flat[]stringfetchAIACertificatesDetailedearly-return onMaxTotalCertsnow returns a properly populatedaiaFetchCertificatesResultResolveAIAde-duplication uses a locked MemStore helper instead of direct map access (fixes data race under concurrent store operations)MemStore concurrency (
internal/certstore/memstore.go)Bundle chain verification (
bundle.go)Test Plan
TestSaveToSQLite_*tests pass, including newTestSaveToSQLite_ReplaceRaceKeepsCompetingWriterWhenHardLinksUnsupportedGOOS=js GOARCH=wasm go build ./cmd/wasm/...)go vet ./...cleanChecklist
CHANGELOG.mdupdated (if user-facing change)💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.