Code cleanup + Use symlinks instead of resolver + Misc optimizations - #25
Open
israelroldan wants to merge 5 commits into
Open
Code cleanup + Use symlinks instead of resolver + Misc optimizations#25israelroldan wants to merge 5 commits into
israelroldan wants to merge 5 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR consists of a big refactor in order to improve the manageability of the codebase and make mondorepo as a cli tool more friendly to the end users.
Summary of the main changes:
mondoreposuitable to work with open source packages, removing the need to include mondorepo-specific code in projects.confas configuration file backend: Allows for cross browser support and a clean API to get, set and clear configuration parameters.oraas a dependency: For the time being, messages logged to the console are back to plain old lines. Whileorais a nice-to-have, it was not correctly implemented and made the code difficult to maintain. We can revisit this in the future as an enhancement.execcommand: Since known packages are now symlinked, there's no need to have a dedicatedexeccommand anymore. Plain oldnode script.jswill do it just fine.npminstead ofyarn: While a little buggy (see comments on cli/install.js,npm@5offers some features that makeyarnan unnecessary default, we can revisit adding it in the future.cliandlib: This will help us manage the codebase a bit better.