Cleanup test cases - #138
Open
mhungen wants to merge 4 commits into
Open
Conversation
|
|
…ructure the test case files provided 16 columns instead of the expected 12
mhungen
force-pushed
the
cleanup_test_cases
branch
2 times, most recently
from
November 19, 2024 11:40
6712ca3 to
055c7fe
Compare
mhungen
force-pushed
the
cleanup_test_cases
branch
from
November 19, 2024 11:41
055c7fe to
76e5326
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
I am currently working on a python port of the s2tbx biophysical models.
I have used your auxdata files which contain the model parameters and conveniently a set of test case files.
However, I think there is something wrong with some of the test cases.
Some do not make sense because the structure does not match the model inputs (assuming I’ve correctly interpreted everything).
All test cases of S2B_10m should have 7 columns (6 input, 1 result), but they have 12. All of them are identical to the test cases in S2B, so this looks like a copy & paste error.
S2A & S2B test cases for LAI_Cw provide 16 columns, i would expect 12 (11 inputs, 1 result)
And there are also some test cases that fail if i add them to your implementation
To be fair, your code doesn’t use these test cases, but the files are quite large and some of them are clearly wrong. I suggest removing them.