Skip to content

Show analysis service keyword as code across service listings#2963

Open
ramonski wants to merge 3 commits into
2.xfrom
2.x-service-keyword-code
Open

Show analysis service keyword as code across service listings#2963
ramonski wants to merge 3 commits into
2.xfrom
2.x-service-keyword-code

Conversation

@ramonski

@ramonski ramonski commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

Description of the issue/feature this PR addresses

Analyses that share the same title (for example several Cs-137 services backed by different methods) are hard to tell apart in the various service listings. This PR surfaces the analysis service keyword consistently, rendered as a <code> chip, so they can be distinguished at a glance.

Current behavior before PR

  • The AR "Manage Analyses" view shows only the service title, no keyword.
  • The "Manage Partitions" view lists analyses by title only, with no keyword and no service info icon.
  • Several service listings already had a Keyword column but rendered it as plain text, inconsistent with the services widget which uses <code>.

Desired behavior after PR is merged

  • The AR "Manage Analyses" view gains a Keyword column rendered as <code>.
  • The Analysis Services control panel, specification, profile, services and AR template analyses widgets all render the keyword as <code>.
  • The "Manage Partitions" view shows the keyword in parentheses next to the analysis name and adds the service info icon (with the same overlay popup used elsewhere).
  • Clicking the partition info icon no longer toggles the analysis checkbox.
  • The partition caret icon no longer stays stuck in the expanded position after an info overlay re-dispatches DOMContentLoaded (the collapse handlers are now bound once, idempotently).

--
I confirm I have tested this PR thoroughly and coded it according to PEP8 and Plone's Python styleguide standards.

ramonski added 2 commits June 26, 2026 07:32
Render the analysis service keyword consistently as a <code> chip in the
service/analysis listings so analyses that share a title (e.g. several
"Cs-137" services) can be told apart by their keyword.

- Add a Keyword column to the AR "Manage Analyses" view
- Wrap the keyword in <code> in the Analysis Services control panel, the
  specification, profile, services and AR template analyses widgets
- In the partition "Manage Partitions" view, show the keyword in
  parentheses next to the analysis name and add the service info icon
- Fix the partition row click handler so clicking the info icon no longer
  toggles the analysis checkbox
- Fix the partition caret icon staying stuck after an info overlay
  re-dispatches DOMContentLoaded by binding the collapse handlers once
@ramonski ramonski requested a review from xispa June 26, 2026 05:37
@ramonski ramonski added the Enhancement ✨ Improvement to existing functionality label Jun 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Enhancement ✨ Improvement to existing functionality

Development

Successfully merging this pull request may close these issues.

1 participant