Show analysis service keyword as code across service listings#2963
Open
ramonski wants to merge 3 commits into
Open
Show analysis service keyword as code across service listings#2963ramonski wants to merge 3 commits into
ramonski wants to merge 3 commits into
Conversation
Render the analysis service keyword consistently as a <code> chip in the service/analysis listings so analyses that share a title (e.g. several "Cs-137" services) can be told apart by their keyword. - Add a Keyword column to the AR "Manage Analyses" view - Wrap the keyword in <code> in the Analysis Services control panel, the specification, profile, services and AR template analyses widgets - In the partition "Manage Partitions" view, show the keyword in parentheses next to the analysis name and add the service info icon - Fix the partition row click handler so clicking the info icon no longer toggles the analysis checkbox - Fix the partition caret icon staying stuck after an info overlay re-dispatches DOMContentLoaded by binding the collapse handlers once
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the issue/feature this PR addresses
Analyses that share the same title (for example several
Cs-137services backed by different methods) are hard to tell apart in the various service listings. This PR surfaces the analysis service keyword consistently, rendered as a<code>chip, so they can be distinguished at a glance.Current behavior before PR
<code>.Desired behavior after PR is merged
<code>.<code>.DOMContentLoaded(the collapse handlers are now bound once, idempotently).--
I confirm I have tested this PR thoroughly and coded it according to PEP8 and Plone's Python styleguide standards.