Remove the obsolete RegulatoryInspector role#2962
Open
ramonski wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the issue/feature this PR addresses
The
RegulatoryInspectorrole and itsRegulatoryInspectorsgroup are no longer used by SENAITE. They remained wired into the rolemap, every workflow definition, the worksheet access logic and the test suite as dead weight. This PR removes them and adds an upgrade step that cleans existing installations.Current behavior before PR
RegulatoryInspectoris declared inrolemap.xmland grantedView,Access contents information,List folder contents,View Labels,View ResultsandView Navigation, plus state permissions across 11 workflow definitions.setuphandlers.pycreates aRegulatoryInspectorsgroup mapped to the role.Worksheet.checkUserAccess,is_privileged_userin the worksheet folder views).Desired behavior after PR is merged
Manager/LabManageras before (the role added nothing the other privileged roles did not already grant).2746->2747) removes the role fromportal_role_manager(which also clears any direct assignments), removes theRegulatoryInspectorsgroup, and drops the role from the portal's known roles, so existing sites are cleaned on upgrade.Tests
The affected doctests pass:
--
I confirm I have tested this PR thoroughly and coded it according to PEP8
and Plone's Python styleguide standards.